Commits on Aug 31, 2021

1. Make SessionRepositoryRequestWrapper::commitSession idempotent …

   Before this commit, commitSession could be called twice, which cause unnecessary access to sessionRepository
   1. closing response output stream by other filter
   	SessionRepositoryFilter$SessionRepositoryRequestWrapper.commitSession() line: 217
   	SessionRepositoryFilter$SessionRepositoryResponseWrapper.onResponseCommitted() line: 180
   	SessionRepositoryFilter$SessionRepositoryResponseWrapper(OnCommittedResponseWrapper).doOnResponseCommitted() line: 227
   	OnCommittedResponseWrapper$SaveContextServletOutputStream.close() line: 505
   	LoggingBodyHttpServletResponse$ResponseServletOutputStream.close() line: 145 // other HttpServletResponse wrapper
   	RestFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 87 // other filter
   	ApplicationFilterChain.internalDoFilter(ServletRequest, ServletResponse) line: 189
   	ApplicationFilterChain.doFilter(ServletRequest, ServletResponse) line: 162
   2. finally statement in SessionRepositoryFilter::doFilterInternal
   	SessionRepositoryFilter$SessionRepositoryRequestWrapper.commitSession() line: 217
   	SessionRepositoryFilter<S>.doFilterInternal(HttpServletRequest, HttpServletResponse, FilterChain) line: 145
   	SessionRepositoryFilter<S>(OncePerRequestFilter).doFilter(ServletRequest, ServletResponse, FilterChain) line: 82
   	ApplicationFilterChain.internalDoFilter(ServletRequest, ServletResponse) line: 189
   	ApplicationFilterChain.doFilter(ServletRequest, ServletResponse) line: 162

   

   quaff committed Aug 31, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 433116f
   • Browse repository at this point

   Copy the full SHA

   433116f View commit details

   Browse the repository at this point in the history