Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SessionRepositoryFilter::setCommitSessionOncePerRequest #2394

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Aug 10, 2023

Fix #1424
See #1910

@quaff
Copy link
Contributor Author

quaff commented Aug 10, 2023

Please review @rwinch @vpavic

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 10, 2023
@marcusdacoregio
Copy link
Contributor

I'm closing this since it has been discussed in the past in #1910

@marcusdacoregio marcusdacoregio self-assigned this Sep 1, 2023
@marcusdacoregio marcusdacoregio added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 1, 2023
@quaff
Copy link
Contributor Author

quaff commented Sep 2, 2023

I'm closing this since it has been discussed in the past in #1910

There is no discussion on this new option, previous discussion point out the change is not safe for some use case, this PR introduce an option default to false which will break nothing, allow user enable it if them want, I think this PR should be reopen, WDYT? @vpavic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionRepositoryFilter's getRequestedSession is called unnecessarily.
3 participants