Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MongoSession as public final #3041

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Expose MongoSession as public final #3041

merged 1 commit into from
Jun 17, 2024

Conversation

Survival1sm
Copy link

Exposes MongoSession as public final along with constructors.

Closes: #2217

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 14, 2024
@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Jun 17, 2024

Hi @Survival1sm, would you please squash your commits into one and change the commit message to:

Make MongoSession public final

Closes gh-2217

Make sure that you run ./gradlew format checkstyleMain as well.

@marcusdacoregio marcusdacoregio self-assigned this Jun 17, 2024
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement in: mongo-db and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 17, 2024
@Survival1sm
Copy link
Author

Survival1sm commented Jun 17, 2024

Hi @Survival1sm, would you please squash your commits into one and change the commit message to:

Make MongoSession public final

Closes gh-2217

Make sure that you run ./gradlew format checkstyleMain as well.

Hi @marcusdacoregio,

Commits squashed with updated message.

Regarding checkstyle, running ./gradlew format checkstyleMain returns the following error for me:

Reason: Task ':spring-session-core:compileJava' uses this output of task ':spring-session-core:formatMain' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

If I add:

tasks.named("formatMain") {
    dependsOn(tasks.named("compileJava"))
    dependsOn(tasks.named("checkstyleMain"))
}

to each modules build.gradle, this allows ./gradlew format checkstyleMain to run but returns success with no issues.

Running ./gradlew format checkstyleMain on the main branch with the above gradle task changes shows the style issues exist in spring-session-core DefaultCookieSerializer.java.

@marcusdacoregio marcusdacoregio added this to the 3.4.0-M1 milestone Jun 17, 2024
@marcusdacoregio marcusdacoregio merged commit a7fe5e1 into spring-projects:main Jun 17, 2024
2 of 3 checks passed
@Survival1sm Survival1sm deleted the 3.3.x-public-mongo-session branch June 20, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoSession should be public
3 participants