Skip to content

Quotes Should Not Be Recognized In Comments #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jlevy-bigfootbiomedical opened this issue Apr 3, 2019 · 2 comments · May be fixed by #1087
Open

Quotes Should Not Be Recognized In Comments #277

jlevy-bigfootbiomedical opened this issue Apr 3, 2019 · 2 comments · May be fixed by #1087
Labels
branch/3.3.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx
Milestone
3.4.1

Comments

@jlevy-bigfootbiomedical
Copy link

jlevy-bigfootbiomedical commented Apr 3, 2019 •
edited
Loading

Both double and single quotes are recognized (or "active") inside of comments, which I think is a bug. The following two line Spring Shell script will not print help:
// don't do this
help

And if you put those two lines in a file, and try to run it with the at-sign on the command line, it will crash and you will get this:
Caused by: org.jline.reader.EOFError: Missing closing quote
@dougbot01
Copy link

I also have found this to be a problem, especially when running script files as mentioned.

Is there a way to up-vote a fix for this? If someone can point to where this might be broken (spring shell vs jLine) maybe I can dig into a fix.

polo7 added a commit to polo7/spring-shell that referenced this issue Jun 8, 2024
@polo7
spring-projectsgh-277: parse commented line like an empty line
33757f3
@polo7 polo7 linked a pull request Jun 8, 2024 that will close this issue
Open
@polo7
Copy link

polo7 commented Jun 8, 2024 •
edited
Loading

Dear colleagues, I've created a PR to fix this issue. Could you please approve merging if there are no objections.
@jvalkeal

@fmbenhassine fmbenhassine added this to the 3.4.1 milestone Apr 25, 2025
@fmbenhassine fmbenhassine added type/backport Is a issue to track backport, use with branch/xxx branch/3.3.x Issue for a branch labels Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch/3.3.x Issue for a branch type/backport Is a issue to track backport, use with branch/xxx
Projects
None yet
Milestone
3.4.1
Development

Successfully merging a pull request may close this issue.

Parse commented lines like an empty lines polo7/spring-shell
4 participants
@fmbenhassine @dougbot01 @jlevy-bigfootbiomedical @polo7