Skip to content

Conversation

Eskibear
Copy link
Contributor

@Eskibear Eskibear commented Apr 6, 2022

A patch for PR #751, otherwise it won't work. Fixing two problems:

  • inconsistent name of argument between API definition and implmentation.
  • didn't return the result in getLiveProcessData

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Contributor Author

Eskibear commented Apr 6, 2022

BTW, you can test the APIs within a simple vscode extension, using below code snippet.

    const stsExt = vscode.extensions.getExtension("pivotal.vscode-spring-boot");
    const stsApi: ExtensionAPI = await stsExt?.activate();

    stsApi.onDidLiveProcessConnect(e => console.log("connect", e));
    stsApi.onDidLiveProcessDisconnect(e => console.log("disconnect", e));
    stsApi.onDidLiveProcessUpdate(async e => {
        console.log("update", e);
        const beans = await stsApi.getLiveProcessData({
            processKey: e,
            endpoint: "beans"
        });
        console.log(beans);
    });
    

@BoykoAlex BoykoAlex merged commit f7ec759 into spring-projects:main Apr 6, 2022
@martinlippert martinlippert added this to the 4.14.1.RELEASE milestone Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants