Skip to content

Incorporate metrics into Spring Web Services [SWS-1024] #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gregturn opened this issue Jun 6, 2018 · 1 comment
Open

Incorporate metrics into Spring Web Services [SWS-1024] #1094

gregturn opened this issue Jun 6, 2018 · 1 comment
Labels
type: enhancement A general enhancement
Milestone
General Backlog

Comments

@gregturn
Copy link
Contributor

gregturn commented Jun 6, 2018

Greg Turnquist opened SWS-1024 and commented

Affects: 3.0.1

0 votes, 5 watchers
@gregturn gregturn added the status: waiting-for-triage An issue we've not yet triaged label Sep 22, 2020
@johkin
Copy link
Contributor

johkin commented Sep 24, 2024 •
edited
Loading

Would it be of use to add support for Micrometer Observations for WebServiceTemplate and perhaps also for server Endpoints?
Seems like this would require to add a dependency to Micrometer Observation and possibly request som modifications in the Spring Boot project?
From the Observation api it's possible to add support for Micrometer Metrics, and possibly also Tracing (but I haven't looked into Tracing details).

johkin added a commit to johkin/spring-ws that referenced this issue Nov 9, 2024
@johkin
Add Observation implementation
904785e 
spring-projects#1094
@johkin johkin mentioned this issue Nov 9, 2024
Merged
johkin added a commit to johkin/spring-ws that referenced this issue Nov 9, 2024
@johkin
Move versions to parent pom properties
50b65c8 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 10, 2024
@johkin
Set micrometer dependency as optional
cf3ce5e 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 10, 2024
@johkin
Add license header and documentation
260e1fb 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 11, 2024
@johkin
Add Javadoc
d98b61a 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 11, 2024
@johkin
Minor modifications after review
f115593 
Changed name of key "localname" to "localpart"
Removed superfluos method implementations
Modified implementation of ContextualName

spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 11, 2024
@johkin
Add Javadoc
8ced9dd 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 12, 2024
@johkin
Updated ContextualName to match Span name conventions
f6bd230 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 14, 2024
@johkin
Minor changes after review
a7df585 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 15, 2024
@johkin
Replaced Assert with WarnThenDebugLogger
8de1a8f 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 18, 2024
@johkin
Modified log-message
a2910e1 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 18, 2024
@johkin
Added nullability annotations
dbdec8a 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 18, 2024
@johkin
Improved exeptionhandling and logging
f486fdc 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 19, 2024
@johkin
Extract common logic to ObservationHelper
4cd4254 
spring-projects#1094
johkin added a commit to johkin/spring-ws that referenced this issue Nov 27, 2024
@johkin
Fix for DomSource-handling
7163362 
spring-projects#1094
corneil pushed a commit that referenced this issue Dec 18, 2024
@johkin
Add Observation implementation (#1438)
f8ba714 
* Add Observation implementation
* Move versions to parent pom properties
* Set micrometer dependency as optional
* Add license header and documentation
* Add Javadoc

Changed name of key "localname" to "localpart"
Removed superfluos method implementations
Modified implementation of ContextualName

* Updated ContextualName to match Span name conventions
* Replaced Assert with WarnThenDebugLogger
* Modified log-message
* Added nullability annotations
* Improved exeptionhandling and logging
* Extract common logic to ObservationHelper
* Fix for DomSource-handling

See #1094
@johkin johkin mentioned this issue Dec 18, 2024
Open
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 7, 2025
@snicoll snicoll added this to the 4.1.0-M1 milestone Mar 7, 2025
snicoll pushed a commit to snicoll/spring-ws that referenced this issue Mar 11, 2025
@johkin @snicoll
Add Observation implementation
505d7f2 
* Add Observation implementation
* Move versions to parent pom properties
* Set micrometer dependency as optional
* Add license header and documentation
* Add Javadoc

Changed name of key "localname" to "localpart"
Removed superfluos method implementations
Modified implementation of ContextualName

* Updated ContextualName to match Span name conventions
* Replaced Assert with WarnThenDebugLogger
* Modified log-message
* Added nullability annotations
* Improved exeptionhandling and logging
* Extract common logic to ObservationHelper
* Fix for DomSource-handling

See spring-projectsgh-1094
snicoll added a commit to snicoll/spring-ws that referenced this issue Mar 11, 2025
@snicoll
Polish "Add Observation implementation"
c2a7f15 
See spring-projectsgh-1094
@snicoll snicoll modified the milestones: 4.1.0-M1, 4.1.x Mar 12, 2025
bclozel pushed a commit to bclozel/spring-ws that referenced this issue Mar 27, 2025
@johkin @bclozel
Add Observation implementation
0f9fd74 
* Add Observation implementation
* Move versions to parent pom properties
* Set micrometer dependency as optional
* Add license header and documentation
* Add Javadoc

Changed name of key "localname" to "localpart"
Removed superfluos method implementations
Modified implementation of ContextualName

* Updated ContextualName to match Span name conventions
* Replaced Assert with WarnThenDebugLogger
* Modified log-message
* Added nullability annotations
* Improved exeptionhandling and logging
* Extract common logic to ObservationHelper
* Fix for DomSource-handling

See spring-projectsgh-1094
bclozel pushed a commit to bclozel/spring-ws that referenced this issue Mar 27, 2025
@snicoll @bclozel
Polish "Add Observation implementation"
9e0badd 
See spring-projectsgh-1094
@snicoll snicoll removed this from the 4.1.x milestone Apr 7, 2025
@snicoll snicoll added this to the General Backlog milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
General Backlog
Development

No branches or pull requests
3 participants
@gregturn @snicoll @johkin