Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[optimization] avoid running symbol indexing and cache write for empty affected files array #1124

Closed
martinlippert opened this issue Oct 15, 2023 · 1 comment
Labels

Comments

@martinlippert
Copy link
Member

When a file is changed, the symbol indexer updates the symbols, and index, diagnostics for this changed file. It also takes care of re-running the indexing on affected files (files that might be affected by a change in the file that we got the change notification from). This happens, for example, if a symbol of source file A.java contains information from B.java. When B.java changes, the symbol indexing etc. needs to re-run on A.java as well, even though the file A.java itself didn't change.

Unfortunately, even if there is no affected file around (which will be the case in the majority of cases), the machinery around this runs and the (unchanged) cache is being written to disc again. We should avoid that.

@martinlippert
Copy link
Member Author

Fixed with 99032f1

@martinlippert martinlippert changed the title avoid running symbol indexing and cache write for empty affected files array [optimization] avoid running symbol indexing and cache write for empty affected files array Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant