Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optimization] avoid writing spring index cache twice on didSave event #1143

Closed
martinlippert opened this issue Nov 8, 2023 · 1 comment
Closed

[optimization] avoid writing spring index cache twice on didSave event #1143

martinlippert opened this issue Nov 8, 2023 · 1 comment
Assignees
@martinlippert
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: performance type: enhancement
Milestone
4.21.0.RELEASE

Comments

@martinlippert
Copy link
Member

If the client sends a didSave event as well as a fileUpdated event, the Spring indexer for Java files writes the cache twice, even though It checks whether certain files have been changed since the last cache update.
@martinlippert martinlippert added type: enhancement theme: performance for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode labels Nov 8, 2023
@martinlippert martinlippert added this to the 4.21.0.RELEASE milestone Nov 8, 2023
@martinlippert martinlippert self-assigned this Nov 8, 2023
martinlippert added a commit that referenced this issue Nov 8, 2023
@martinlippert
GH-1143: avoid writing cache if no files have changed
950d528
@martinlippert
Copy link
Member Author

Fixed with 950d528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinlippert martinlippert

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: performance type: enhancement
Projects
None yet
Milestone
4.21.0.RELEASE
Development

No branches or pull requests
1 participant
@martinlippert