Force balance tags in news #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue that causes nested news items when BBCode isn't parsed properly and HTML tags are opened but not closed. The force_balance_tags function is derived from WordPress which itself uses a fork. The alternative is a DOMDocument, but this avoids encoding issues and has been battle hardened by running on hundreds of millions of sites for 19 years
|
shouldn't the bbcode parser be fixed? |
|
yes but I’m not familiar with the BBCode parser and it’s a nice separation
of concerns so I’d still add the function anyway
…On Thu, 2 Jun 2022 at 10:06, abma ***@***.***> wrote:
shouldn't the bbcode parser be fixed?
—
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOLZ66QSD7HP63XMCLD7DVNB2RZANCNFSM5XLT2UFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
ok. i guess i'll try https://github.com/genert/bbcode or then: this project didn't exist the last time i searched for a bbcode parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that causes nested news items when BBCode isn't parsed properly and HTML tags are opened but not closed.
The force_balance_tags function is derived from WordPress which itself uses a fork. The alternative is a DOMDocument, but this avoids encoding issues and has been battle hardened by running on hundreds of millions of sites for 19 years