Skip to content

Eliminate afterEvaluate #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ plugins {
`java-gradle-plugin`
id("com.gradle.plugin-publish") version "0.14.0"
id("org.sonarqube") version "3.1.1"
kotlin("jvm") version "1.4.31"
kotlin("jvm") version "1.8.21"
`maven-publish`
id("com.github.ben-manes.versions") version "0.38.0"
id("io.gitlab.arturbosch.detekt") version "1.16.0"
}

group = "org.springdoc"
version = "1.6.0"
version = "1.6.1-SNAPSHOT"

sonarqube {
properties {
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@ import com.github.psxpaul.task.JavaExecFork
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.Task
import org.gradle.api.logging.Logging
import org.gradle.api.UnknownDomainObjectException
import org.gradle.api.tasks.TaskProvider
import org.gradle.internal.jvm.Jvm
import org.springframework.boot.gradle.tasks.run.BootRun

open class OpenApiGradlePlugin : Plugin<Project> {
private val logger = Logging.getLogger(OpenApiGradlePlugin::class.java)

override fun apply(project: Project) {
with(project) {
Expand All @@ -20,7 +19,7 @@ open class OpenApiGradlePlugin : Plugin<Project> {

extensions.create(EXTENSION_NAME, OpenApiExtension::class.java, this)

afterEvaluate { generate(this) }
generate(this)
}
}

Expand All @@ -30,14 +29,22 @@ open class OpenApiGradlePlugin : Plugin<Project> {
// The task, used to run the Spring Boot application (`bootRun`)
val bootRunTask = tasks.named(SPRING_BOOT_RUN_TASK_NAME)
// The task, used to resolve the application's main class (`bootRunMainClassName`)
val bootRunMainClassNameTask = tasks.find { it.name == SPRING_BOOT_RUN_MAIN_CLASS_NAME_TASK_NAME}
?:tasks.named(SPRING_BOOT_3_RUN_MAIN_CLASS_NAME_TASK_NAME)
val bootRunMainClassNameTask =
try {
val task=tasks.named(SPRING_BOOT_RUN_MAIN_CLASS_NAME_TASK_NAME)
logger.debug("Detected Spring Boot task {}", SPRING_BOOT_RUN_MAIN_CLASS_NAME_TASK_NAME)
task
} catch (e: UnknownDomainObjectException) {
val task=tasks.named(SPRING_BOOT_3_RUN_MAIN_CLASS_NAME_TASK_NAME)
logger.debug("Detected Spring Boot task {}", SPRING_BOOT_3_RUN_MAIN_CLASS_NAME_TASK_NAME)
task
}

val extension = extensions.findByName(EXTENSION_NAME) as OpenApiExtension
val customBootRun = extension.customBootRun
// Create a forked version spring boot run task
val forkedSpringBoot = tasks.register(FORKED_SPRING_BOOT_RUN_TASK_NAME, JavaExecFork::class.java) { fork ->
fork.dependsOn(bootRunMainClassNameTask)
fork.dependsOn(tasks.named(bootRunMainClassNameTask.name))
fork.onlyIf { needToFork(bootRunTask, customBootRun, fork) }
}

Expand All @@ -54,8 +61,9 @@ open class OpenApiGradlePlugin : Plugin<Project> {
val tasksNames = tasks.names
val boot2TaskName = "bootRunMainClassName"
val boot3TaskName = "resolveMainClassName"
if (!tasksNames.contains(boot2TaskName) && tasksNames.contains(boot3TaskName))
if (!tasksNames.contains(boot2TaskName) && tasksNames.contains(boot3TaskName)) {
tasks.register(boot2TaskName) { it.dependsOn(tasks.named(boot3TaskName)) }
}
}

private fun needToFork(
Expand Down