Fix toolbar buttons appearing broken when no label or icon is set #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes two things:
label
oricon
are now hidden from the toolbar. Those two props have always been optional, but having neither really doesn’t achieve anything useful for users. This also makes it easier to implement custom controls (e.g. color picker for inline styles, or text styles drawer).label
tonull
(thus overriding the built-in labels).I also added a demo of building a text styles drawer as part of the "controls" doc, which depends on those changes.
npm run test:coverage
)npm run lint
)Thanks for contributing to Draftail!