-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django-allauth integration #108
base: main
Are you sure you want to change the base?
Conversation
@@ -190,7 +202,7 @@ | |||
|
|||
# Wagtail settings | |||
|
|||
LOGIN_URL = 'wagtailadmin_login' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is is defined now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All login pages points to django-allauth login page.
Wagtail admin login page is redirect in urls.py
LOGIN_URL
defined in base.py on line 205 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I missed the double assignment WAGTAIL_FRONTEND_LOGIN_URL = LOGIN_URL = ...
docs/allauth-social-accounts.md
Outdated
- [x] `'allauth.socialaccount.providers.google'` in `INSTALLED_APPS` | ||
|
||
### Configuration in Google developer console | ||
- [ ] [Create a new project](https://console.developers.google.com/projectcreate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe some of those steps to be done already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a testing project to run it and test it locally. A new project (owned by somebody else than me) should be created for the live site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the back-end work but as discussed offline, it will need some styling before merging.
d4f170d
to
84155b3
Compare
@mojeto I found out today that there is a |
Good spotting @loicteixeira . We allow user password authentication in allauth. So keeping WAGTAIL_PASSWORD_MANAGEMENT_ENABLED means we may set user password in admin - good to keep that option. I would think more about |
84155b3
to
79c3263
Compare
Ref #70