Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jms): JMS support #432

Merged
merged 16 commits into from
Nov 24, 2023
Merged

feat(jms): JMS support #432

merged 16 commits into from
Nov 24, 2023

Conversation

krzysztofxkwiecien
Copy link
Contributor

This PR adds support for JMS @JmsListener annotation, as requested in #173
The code is based on the sqs plugin and example, with no changes made other than what was necessary to use jms instead of sqs

Copy link

netlify bot commented Nov 5, 2023

Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit d548b56
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/655bdfdcca61970009c18f80

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Springwolf. Thanks a lot for creating your first pull request. Please check out our contributors guide and feel free to join us on discord.

@timonback
Copy link
Member

Hi @krzysztofxkwiecien
Great contribution! We will have a look next Friday.

@timonback
Copy link
Member

Great to see that you updated the readme as well. Can you add jms to the springwolf-ui mock-server.ts as well? This allows the demo website to show the jms example.

@krzysztofxkwiecien
Copy link
Contributor Author

Sure! let me know if anything else needs updating

@timonback
Copy link
Member

Hi @krzysztofxkwiecien,
thank you for this contribution. We like it and resolved the issue with the test setup.

Can you add tests for:

  • SpringwolfJmsController (you can refer to SpringwolfKafkaControllerTest for the setup)
  • JmsMessageBindingProcessor
  • JmsOperationBindingProcessor

@timonback timonback merged commit 491e1aa into springwolf:master Nov 24, 2023
15 checks passed
@timonback
Copy link
Member

Thank you @krzysztofxkwiecien for this big contribution and adding this much wished feature to support JMS.

We plan to release this soon so stay tuned.


We also gather infos about who is using Springwolf. Please comment your company's name in #342 - if can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants