-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API refactory #58
Comments
@mpetrunic @BeroBurny Liviu and I were talking through this, and suggest for the bleeding obviousnessssss aggregateBalance -> bridgeAggregateBalance |
Ooops, I've just seen this. This is a bit innacurate, since aggreateBalance doesn't neccessarilly involve bridge, it could involve, unwrapping, amm or just transfer on the same chain |
what about
|
@BeroBurny that would make sense, but I think it might be confusing for the user. Maybe we need to align naming with intent more.
@MakMuftic @itsbobbyzzz168 WDYT? |
Yep like the last suggestion 👍 I see it is already applied 🎉 |
closes #58 BREAKING CHANGE: All functions renamed, different API and flows, please consult docs or reach out to us directly!
current api naming is not adequate and causing confusion with the users as they aren't sure which method to call. I would propose following methods:
bridge
- calls /solution/call without contract callbridgeAndCall
- calls /solution/call with contract callaggregateBalance
- calls get_solutions_aggregation method. If there is only one network whitelisted, it will callbridge
aggregateBalanceAndCall
- callspost_solutions_aggregation
If there is only one network whitelisted, it will callbridgeAndCall
The text was updated successfully, but these errors were encountered: