Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue with latest node version #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

billoosijok
Copy link

I have node version 8, but I couldn't install sproutcore because it was looking for v8.0 of this package.

@mauritslamers
Copy link
Member

Wouldn't this cause a node v7 package to be installed under node v8? If yes, that could cause problems because of the ABI differences.

@billoosijok
Copy link
Author

Ah! I didn't know, sorry about that. So the only solution right now is to downgrade to node v7?

@mauritslamers
Copy link
Member

mauritslamers commented Aug 7, 2017 via email

@billoosijok
Copy link
Author

How could I get rid of image slicing? The issue I'm facing is that I am not even able to install sproutcore, because it stops at node-canvas. Does that mean I'd have to install it without npm? I'm not sure how to do that properly

@billoosijok
Copy link
Author

Okay so I was finally able to install it using node v7.10.1. I downgraded it using nvm. Also, it had permission issues so I ran it as sudo. Then it installed! Thanks much @mauritslamers

@mauritslamers
Copy link
Member

Great! Sorry for all the trouble. This is slowly asking for a 1.12 version where the slicing is gone. At the same time we are working on a 2.0 release so this complicates things a bit.

@mauritslamers
Copy link
Member

We are about to drop slicing from the BT, which also resolves the base problem here. Slicing will be available (if required) through a separate npm package sproutcore-slicing which will enable slicing if required. As soon as these packages are released, this PR will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants