Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test RevocationList2020Status in VC API #239

Closed
wants to merge 1 commit into from
Closed

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Oct 29, 2021

Add RevocationList2020Status to credentialStatusesSupported in the local VC (HTTP) API Test Suite config, to cause Revocation List 2020 functionality to be tested. This should have been added before, but was forgotten. However, adding it now will probably cause test failure, as the test revocation list credential and its dependent credential statuses have been broken in the renaming of vc-http-api to vc-api: w3c-ccg/vc-api#236

The test suite itself could also be similarly updated for Spruce's demo instance: https://github.com/w3c-ccg/vc-api-test-suite/blob/a74c63d2d015efcb1c5d22a5d283536026faf5ec/packages/vc-http-api-test-server/config/Spruce.js#L18

Edit: actually, this change would cause issuer tests to run as well, which DIDKit doesn't currently support: the credentialStatus issuance option is supposed to result in a credentialStatus object added to the resulting verifiable credential:
https://github.com/w3c-ccg/vc-api-test-suite/blob/a74c63d2d015efcb1c5d22a5d283536026faf5ec/packages/vc-http-api-test-server/__tests__/issueCredential.spec.js#L126-L166

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbihel
Copy link
Member

sbihel commented Oct 25, 2024

Closing old PRs

@sbihel sbihel closed this Oct 25, 2024
@sbihel sbihel deleted the fix/vc-api-test-rl branch October 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants