Add mDoc auth Reader auth #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justAnIdentity
force-pushed
the
feat/mdoc-auth
branch
from
6029784
to
10867e6
Compare
cobward
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Preliminary suggestions to improve the code. I think we need a couple of iterations to make this clearer. Since this is very security sensitive code it is really important that it is obvious what it is doing, it is easy to follow, and it is well documented. That way we can have confidence that it is implemented correctly.
To that effect encapsulating code so that we don't have multi-hundred line validation functions, and adding lots of comments would be very welcome.
cobward
reviewed
Dec 1, 2023
| pub mod test { | ||
|
|
||
| #[test] | ||
| fn test_key_usage() {} |
There was a problem hiding this comment.
Could you write some unit tests or just remove this. Ideally adding some unit tests would be great if you have time.
justAnIdentity
changed the title
author Arjen van Veen <arjen.van.veen@spruceid.com> 1701187280 +0100 committer Arjen van Veen <arjen.van.veen@spruceid.com> 1717744754 +0200 refactor for readability WIP clean up comments and duplicates clean up, add some comments cargo fmt clippy fix fmt assert on tests address pr comments refactor handle_response to return a validated_response, submit parsing and decryption errors under errors support creating a trust_anchor_registry from pem strings Fix x5chain encoding. X5Chain decoding fixes and version checking Improve reader validation code. - Also add a CLI tool for validating issuer certificates. Fix public key parsing Feat/reader auth cn (#79) * rebase onto feat/mdoc-auth * rebase and use mdoc-auth functions * wip experiment with cert building * small clean up * Fix inconsistency. (#78) * validated request improvements --------- Co-authored-by: Jacob <jacob.ward@spruceid.com> remove duplicate code clippy fix
justAnIdentity
force-pushed
the
feat/mdoc-auth
branch
from
d43c6c7
to
b1ec197
Compare
Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
Co-authored-by: Jacob <jacob.ward@spruceid.com> Signed-off-by: Ryan Tate <ryan.tate@spruceid.com>
Ryanmtate
force-pushed
the
feat/mdoc-auth
branch
from
08b461e
to
8085446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.