Improve EIP-712 type string parsing #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyc
approved these changes
Sep 21, 2021
* Test some EIP-712 type string parsing * Catch unmatched bracket in EIP-712 type string
clehner
force-pushed
the
fix/bracket-parsing
branch
from
9df6c8c to
c666c74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A panic in the string parsing was possible, due to calling
.next().unwrap()twice on an iterator that is not known to contain more than one element. Fix by returning an error if the second item in the iterator is none. The first item is expected to always succeed so is unchanged.