Remove use of PassthroughDigest from EthereumPersonalSignature2021 #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do Keccak256 hashing using try_sign and recover_verify_key functions, rather than in hash_personal_message.
sbihel
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to simplify code and reduce reliance on
PassthroughDigest.EthereumPersonalSignature2021insrc/ldp.rsinvolves Keccak256 hashing. This is usingtry_sign_digestandrecover_verify_key_from_digest_byteswithPassthroughDigest.k256includes default signing and verification functions using Keccak256 already, which is used in other places inldp.rs. This PR updatesEthereumPersonalSignature2021to use those functions as well - i.e.try_signandrecover_verify_keywithk256::ecdsa::recoverable::Signature.To ensure the signing still works, a test is added in
did-pkh. Verifying continues to be tested indid-pkhvia static test vectors.