Catch errors in bbs module #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbihel
approved these changes
Nov 3, 2021
- Use Result instead of unwrap in keypair generation and conversion. - Note serialize may panic
|
Rebasing and merging. |
clehner
force-pushed
the
fix/bbs-unwrap
branch
from
b66c355 to
d5549ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes functions using
unwrapinsrc/bbs.rsto instead return aResult. This affects keypair generation and conversion functions. Error types using thiserror are added. This change is intended to make the code safer by being less likely to panic. Although it's possible these uses ofunwrapwould not panic in practice, these changes would then just represent erring on the side of caution.In
impl Serialize for BlsSecretKey, I was unable to remove the use ofunwrap, so instead add a documentation comment that the function may panic.