Detect JSON DID Resolution Result #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clehner
force-pushed
the
feat/did-res-parse
branch
from
1ad1cd1
to
c97028d
Compare
sbihel
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DID Resolution Result has a media type defined in CCG's DID Resolution specification draft, that is a JSON-LD media type with a profile parameter equal to the DID Resolution namespace: https://w3c-ccg.github.io/did-resolution/#did-resolution-result
ssi's HTTP DID resolution client implementation currently depends on this media type being set in a HTTP response.
However, at least one server implementation at this point does not set that specific media type on the response: ion's implementation uses
application/json.This PR enables using ssi with DIF's ion implementation's DID resolver endpoint. There's also a PR on ion to set the more specific media type: decentralized-identity/ion#244.
Similar handling for dereference is not added as there is no need for it currently.