Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy CI and warnings #467

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix Clippy CI and warnings #467

merged 1 commit into from
Oct 6, 2022

Conversation

sbihel
Copy link
Member

@sbihel sbihel commented Oct 5, 2022

Only running for default features for now. Had to fix a couple of Cargo.toml.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Close #227
@sbihel sbihel requested review from chunningham and cobward October 5, 2022 17:09
@@ -5,7 +5,7 @@ edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
[features]
default = ["secp256k1", "secp256r1", "ed25519", "rsa", "eip", "ssi-jwk/ripemd-160"]
default = ["secp256k1", "secp256r1", "ed25519", "rsa", "eip", "ssi-jwk/ripemd-160", "blake2b_simd"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we ever not use simd?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, thanks past me, for once

// We will be able to use the blake2 crate directly once it allow 32B output

Which is a piece of work that I might be able to do now, it was tied to #385

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I misread your message, I guess it should be a dependency of other dependencies instead, I'll address it with the above

@sbihel sbihel merged commit 5f635fc into main Oct 6, 2022
@sbihel sbihel deleted the fix/clippy branch October 6, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants