Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPESC-8668 Fixed validation for deprecated features. #65

Merged

Conversation

olhalivitchuk
Copy link
Contributor

@olhalivitchuk olhalivitchuk added the bug Something isn't working label Jul 24, 2024
Copy link

tests/Acceptance/_data/InvalidProject/composer.lock

Package changes

Package Operation From To About
spryker-feature/customer-notes add - 202009.0 view code - License: proprietary

Settings · Docs · Powered by Private Packagist


$commandTester->assertCommandIsSuccessful();
}
// public function testReturnSuccessOnValidProject(): void
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, thanks for noticing

Copy link
Contributor

@vol4onok vol4onok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one bad thing that we need to support this list. will be better to have an API for depricated packages. But it's techDept.

@vol4onok vol4onok merged commit 9bb928a into master Jul 26, 2024
4 checks passed
@vol4onok vol4onok deleted the bugfix/supesc-8668/fixed-evaluator-for-deprecated-features branch July 26, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants