[CC-33995] Keyboard accessible B2B #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supproduction
requested changes
Dec 19, 2024
src/Pyz/Yves/CatalogPage/Theme/default/templates/page-layout-catalog/page-layout-catalog.twig
Outdated
Show resolved
Hide resolved
.../Yves/CheckoutPage/Theme/default/components/molecules/summary-overview/summary-overview.twig
Outdated
Show resolved
Hide resolved
src/Pyz/Yves/CompanyPage/Theme/default/templates/page-layout-company/page-layout-company.twig
Outdated
Show resolved
Hide resolved
...Pyz/Yves/CustomerPage/Theme/default/templates/page-layout-customer/page-layout-customer.twig
Outdated
Show resolved
Hide resolved
...yz/Yves/ProductImageWidget/Theme/default/components/molecules/image-gallery/image-gallery.ts
Outdated
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/molecules/custom-select/custom-select.scss
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/molecules/date-time-picker/date-time-picker.ts
Outdated
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/molecules/date-time-picker/date-time-picker.ts
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/organisms/header/header.twig
Outdated
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/templates/page-layout-main/page-layout-main.twig
Outdated
Show resolved
Hide resolved
supproduction
requested changes
Dec 19, 2024
src/Pyz/Yves/CatalogPage/Theme/default/templates/page-layout-catalog/page-layout-catalog.twig
Outdated
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/molecules/custom-select/custom-select.scss
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/molecules/date-time-picker/date-time-picker.ts
Outdated
Show resolved
Hide resolved
src/Pyz/Yves/ShopUi/Theme/default/components/organisms/header/header.twig
Outdated
Show resolved
Hide resolved
supproduction
requested changes
Jan 6, 2025
| @@ -2,7 +2,16 @@ | |||
|
|
|||
| {% block contentClass %}page-layout-main page-layout-main--catalog-page{% endblock %} | |||
|
|
|||
| {% set catalogProductListId = 'catalog-product-list' %} | |||
There was a problem hiding this comment.
We don't need to redefine it, as we have it in core. Please, recheck in all templates/components
Comment on lines
+19
to
+21
| {% define attributes = { | ||
| navigationId: '', | ||
| } %} |
There was a problem hiding this comment.
Can we use header from core? and omit all this params redefining?
Comment on lines
10
to
+29
| {%- block class -%}{{ pageLayoutMainJsClassName }}__side-drawer-container{%- endblock -%} | ||
|
|
||
| {% set navigationId = 'main-navigation' %} | ||
| {% set mainContentId = 'main-content' %} | ||
|
|
||
| {% block body %} | ||
| {% include molecule('skip-link') with { | ||
| data: { | ||
| href: navigationId, | ||
| text: 'global.skip-to-navigation' | trans, | ||
| }, | ||
| } only %} | ||
|
|
||
| {% include molecule('skip-link') with { | ||
| data: { | ||
| href: mainContentId, | ||
| text: 'global.skip-to-content' | trans, | ||
| }, | ||
| } only %} | ||
|
|
There was a problem hiding this comment.
In order if we override only viewport block we can omit all these code duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ticket: https://spryker.atlassian.net/browse/CC-33995
PR with comments to fix [OLD] [CC-33996] Adds keyboard accessibility #570