ACP-3738 Fixed Disconnect message. #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matweew
reviewed
Aug 20, 2024
| @@ -29,7 +29,7 @@ class ConfigWriter implements ConfigWriterInterface | |||
| /** | |||
| * @var string | |||
| */ | |||
| protected const FAILED_TO_REGISTER_TENANT_MESSAGE = 'Tenant registration failed'; | |||
| protected const FAILED_TO_OPERATION_TENANT_MESSAGE = 'Tenant operation failed'; | |||
There was a problem hiding this comment.
Suggested change
| protected const FAILED_TO_OPERATION_TENANT_MESSAGE = 'Tenant operation failed'; | |
| protected const FAILED_TENANT_ACTION_MESSAGE = 'Tenant action failed'; |
| @@ -59,14 +59,14 @@ public function saveConfig(AppConfigTransfer $appConfigTransfer): AppConfigRespo | |||
| return $this->getSuccessResponse($appConfigTransfer); | |||
| } catch (Throwable $throwable) { | |||
| $this->getLogger()->error( | |||
| static::FAILED_TO_REGISTER_TENANT_MESSAGE, | |||
| static::FAILED_TO_OPERATION_TENANT_MESSAGE, | |||
There was a problem hiding this comment.
why is the message is generic here if the method is saveConfig()?
So "Failed to save tenant configuration." is more suitable here
There was a problem hiding this comment.
it processes connect, new, disconnect statuses. you can check doSaveAppConfig
stereomon
requested changes
Aug 20, 2024
| @@ -29,7 +29,7 @@ class ConfigWriter implements ConfigWriterInterface | |||
| /** | |||
| * @var string | |||
| */ | |||
| protected const FAILED_TO_REGISTER_TENANT_MESSAGE = 'Tenant registration failed'; | |||
| protected const FAILED_TO_OPERATION_TENANT_MESSAGE = 'Tenant operation failed'; | |||
There was a problem hiding this comment.
The constant is not in correct English. Should be TENANT_OPERATION_FAILED
…-methods' of https://github.com/spryker/app-kernel into feature/acp-3670/acp-3580/master-klarna-and-pre-payment-methods
stereomon
approved these changes
Aug 20, 2024
matweew
approved these changes
Aug 20, 2024
matweew
deleted the
feature/acp-3670/acp-3580/master-klarna-and-pre-payment-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
https://spryker.atlassian.net/browse/ACP-3738
The message should be more abstract. It's not only registration; it can also be updated and disconnected.
Checklist