-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP-4499: Added console command for post-install setup #20
Merged
pushokwhite
merged 12 commits into
master
from
bugfix/acp-4499-message-broker-conditional-channels-handling
Jan 10, 2025
Merged
ACP-4499: Added console command for post-install setup #20
pushokwhite
merged 12 commits into
master
from
bugfix/acp-4499-message-broker-conditional-channels-handling
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage-broker-conditional-channels-handling # Conflicts: # composer.json
…sage-broker-conditional-channels-handling
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
=============================================
- Coverage 100.00% 94.05% -5.95%
- Complexity 173 232 +59
=============================================
Files 30 39 +9
Lines 627 858 +231
=============================================
+ Hits 627 807 +180
- Misses 0 51 +51 ☔ View full report in Codecov by Sentry. |
stereomon
reviewed
Jan 2, 2025
...Zed/AppKernel/Communication/Plugin/AppKernel/TriggerAppConfigUpdatePostInstallTaskPlugin.php
Show resolved
Hide resolved
stereomon
reviewed
Jan 2, 2025
tests/SprykerTest/Zed/AppKernel/_support/AppKernelCommunicationTester.php
Outdated
Show resolved
Hide resolved
Can you please add a proper description here? |
stereomon
reviewed
Jan 2, 2025
stereomon
reviewed
Jan 2, 2025
stereomon
reviewed
Jan 2, 2025
...Zed/AppKernel/Communication/Plugin/AppKernel/TriggerAppConfigUpdatePostInstallTaskPlugin.php
Show resolved
Hide resolved
stereomon
approved these changes
Jan 10, 2025
pushokwhite
deleted the
bugfix/acp-4499-message-broker-conditional-channels-handling
branch
January 10, 2025 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
AppConfigUpdated
message.setup:post-install
console command to execute post-install actions.TriggerAppConfigUpdatePostInstallTaskPlugin
to keep the Tenant-stored App configuration up-to-date after each App deployment.Steps before you submit a PR
contribution-license-agreement.txt
file with the following content:I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/app-kernel/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.
This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH
is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist