Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-4499: Added console command for post-install setup #20

Merged

Conversation

pushokwhite
Copy link
Contributor

@pushokwhite pushokwhite commented Nov 28, 2024

PR Description

  • Added support for message channels stored in the App configuration, populated via the AppConfigUpdated message.
  • Added setup:post-install console command to execute post-install actions.
  • Added TriggerAppConfigUpdatePostInstallTaskPlugin to keep the Tenant-stored App configuration up-to-date after each App deployment.

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/app-kernel/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.05%. Comparing base (9be15f0) to head (5a931f8).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...yker/Zed/AppKernel/AppKernelDependencyProvider.php 70.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              master      #20      +/-   ##
=============================================
- Coverage     100.00%   94.05%   -5.95%     
- Complexity       173      232      +59     
=============================================
  Files             30       39       +9     
  Lines            627      858     +231     
=============================================
+ Hits             627      807     +180     
- Misses             0       51      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stereomon
Copy link
Collaborator

Can you please add a proper description here?

@pushokwhite pushokwhite merged commit 473f2c7 into master Jan 10, 2025
3 checks passed
@pushokwhite pushokwhite deleted the bugfix/acp-4499-message-broker-conditional-channels-handling branch January 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants