Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-2573: Adjusted logs #5

Merged
merged 7 commits into from
Jun 11, 2024
Merged

ACP-2573: Adjusted logs #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3ff6a09
ACP-2573: Adjusted logs
vol4onok Jun 11, 2024
113e3b1
ACP-2573: Update rector to avoid issue
vol4onok Jun 11, 2024
667137d
ACP-2573: Update rector to avoid issue
vol4onok Jun 11, 2024
1ebd1cd
ACP-2573: Update rector to avoid issue
vol4onok Jun 11, 2024
91eefba
ACP-2573: Update rector to avoid issue
vol4onok Jun 11, 2024
1bf31c9
ACP-2573: fixed cs
vol4onok Jun 11, 2024
1673836
ACP-2573: fixed cs
vol4onok Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
},
"require-dev": {
"codeception/codeception": "^5.0",
"phpstan/phpstan": "^1.10.0",
"phpstan/phpstan": "1.10.66",
"phpstan/phpdoc-parser": "1.25.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version incompatibility. CI is failed. so it's fix for Rector

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be composer.lock updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it shouldn't. it blocks versions in the require section. Core packages should have lock files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core packages should have lock files

yes, but should NOT have.

"rector/rector": "^0.19.0",
"spryker/code-sniffer": "*",
"spryker/container": "*",
Expand Down
8 changes: 7 additions & 1 deletion src/Spryker/Zed/AppKernel/Business/Writer/ConfigWriter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,13 @@ public function saveConfig(AppConfigTransfer $appConfigTransfer): AppConfigRespo

return $this->getSuccessResponse($appConfigTransfer);
} catch (Throwable $throwable) {
$this->getLogger()->error(static::FAILED_TO_REGISTER_TENANT_MESSAGE, ['exception' => $throwable]);
$this->getLogger()->error(
static::FAILED_TO_REGISTER_TENANT_MESSAGE,
[
'tenantIdentifier' => $appConfigTransfer->getTenantIdentifier(),
'exception' => $throwable,
],
);

return $this->getFailResponse(sprintf('%s: %s', static::FAILED_TO_REGISTER_TENANT_MESSAGE, $throwable->getMessage()));
}
Expand Down
2 changes: 1 addition & 1 deletion src/Spryker/Zed/AppKernel/Persistence/AppKernelRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function findAppConfigByCriteria(
$errorMessage = 'Could not find an App configuration for the given Tenant';

$this->getLogger()->error($errorMessage, [
'Tenant' => $appConfigCriteriaTransfer->getTenantIdentifierOrFail(),
'tenantIdentifier' => $appConfigCriteriaTransfer->getTenantIdentifierOrFail(),
]);

throw new AppConfigNotFoundException($errorMessage);
Expand Down
Loading