Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPDoc for ProductStorageDependencyProvider.php #2

Closed
wants to merge 1 commit into from

Conversation

umairkj
Copy link
Contributor

@umairkj umairkj commented Nov 28, 2023

PR Description

getProductConcreteStorageCollectionExpanderPlugins function should return an array of ProductConcreteStorageCollectionExpanderPluginInterface in PHPDocs

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@spryker-release-bot
Copy link
Collaborator

Thank you for providing a pull request to our repository. Can we ask you to complete this 2-question form?
https://www.surveymonkey.de/r/PPNJ5L8

This will help us evaluate and merge your pull request as soon as possible, as well as make sure your contribution is properly recognized.
After sending your answer, our developers will check your PR and reach out to you using the email provided below with clarifying questions and an ETA on when you can expect your contribution to be merged with our core code.

In the meantime, please check that:

  • Your code is free of side effects that could harm other use cases.
  • Your code is tested, ideally a small test case provided along side the change to show the issue is indeed fixed and no regression can sneak in.

With this we can process it even faster and will be able to deliver the fixed module(s) to you with highest quality.

@artem-png
Copy link

Dear @jadoon88,

We want to express our appreciation for your recent contribution to our project.

Your pull request has been diligently reviewed, processed following our internal processes, and successfully merged into our codebase. You can find the commit here.

Thanks a lot for your contribution!

Best,
Spryker Team

@valerio8787 valerio8787 closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants