Migration guide - Upgrade Node.js to v18 and npm to v9 #1854

andrew-maslov · 2023-05-16T11:42:11Z

Ticket: https://spryker.atlassian.net/browse/CC-25660

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

VadymSachenko · 2023-05-30T13:37:54Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+
+## Overview
+
+According to [Node.js schedule](https://github.com/nodejs/release#release-schedule) the 16 version will be maintained till 11.09.2023. So Spryker recommends migrating to 18 LTS version.


Suggested change

According to [Node.js schedule](https://github.com/nodejs/release#release-schedule) the 16 version will be maintained till 11.09.2023. So Spryker recommends migrating to 18 LTS version.

According to [Node.js schedule](https://github.com/nodejs/release#release-schedule), the maintenance of version 16 stops on September 11, 2023. Therefore, we recommend migrating to the 18 LTS version.

VadymSachenko · 2023-05-30T13:38:25Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+
+## 1) Update configuration files
+
+1. Set up new versions of `node/npm` in the main `*.yml` files, like `deploy.yml`, `deploy.dev.yml`, and `deploy.ci.yml`:


Suggested change

1. Set up new versions of `node/npm` in the main `*.yml` files, like `deploy.yml`, `deploy.dev.yml`, and `deploy.ci.yml`:

1. In the main `*.yml` files, set up new versions of `node/npm`, like `deploy.yml`, `deploy.dev.yml`, and `deploy.ci.yml`:

VadymSachenko · 2023-05-30T13:39:02Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+
+{% endinfo_block %}
+
+2. In the root directory, create/update `.nvmrc` file with the following content:


Suggested change

2. In the root directory, create/update `.nvmrc` file with the following content:

2. In the root directory, create or update the `.nvmrc` file with the following content:

VadymSachenko · 2023-05-30T13:39:34Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+18.16.0
+```
+
+3. Update or add dependencies and engines in the `package.json`:


Suggested change

3. Update or add dependencies and engines in the `package.json`:

3. In the `package.json`, update or add dependencies and engines:

VadymSachenko · 2023-05-30T13:40:00Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+}
+```
+
+4. Remove dependency in the `package.json`:


Suggested change

4. Remove dependency in the `package.json`:

4. In the `package.json`, remove the dependency :

VadymSachenko · 2023-05-30T13:41:23Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+```
+
+5. Update webpack config in `frontend/configs/development.js`:
+  - Replace `options` of `postcss-loader`;


If these are steps, then use the numbered list instead of bulleted points. Also, correct grammar:

Suggested change

- Replace `options` of `postcss-loader`;

1. In `postcss-loader`, replace `options`.

VadymSachenko · 2023-05-30T13:44:42Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+
+{% info_block infoBox "Note" %}
+
+Ensure that the `package-lock.json` file has `"lockfileVersion": 2` or higher, otherwise need to remove `node_modules` and `package-lock.json`. After that regenerate again.


Make sure I rephrased the sentence correctly, and that it carries the same meaning.

Suggested change

Ensure that the `package-lock.json` file has `"lockfileVersion": 2` or higher, otherwise need to remove `node_modules` and `package-lock.json`. After that regenerate again.

Ensure that the `package-lock.json` file has `"lockfileVersion": 2` or later; otherwise, remove `node_modules` and `package-lock.json` and regenerate the file again.

VadymSachenko · 2023-05-30T13:45:25Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+{% endinfo_block %}
+
+## 3) Update GitHub Actions
+In case using GitHub Actions on the project need to update `.github/workflows/ci.yml` file.


Should it be step 1?

Suggested change

In case using GitHub Actions on the project need to update `.github/workflows/ci.yml` file.

If you're using GitHub Actions on the project, update the `.github/workflows/ci.yml` file.

VadymSachenko · 2023-05-30T13:45:59Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+
+## 3) Update GitHub Actions
+In case using GitHub Actions on the project need to update `.github/workflows/ci.yml` file.
+Update Node.js version:


Should it be step 2?

VadymSachenko · 2023-05-30T13:46:09Z

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

+      node-version: '18'
+```
+
+Remove npm cache:


Should it be step 3?

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md

...os/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18-and-npm-to-v9.md

…pgrade-nodejs-to-v18-and-npm-to-v9.md

CC-25660: Created migration guide for Node.js

0bb9359

andrew-maslov added the in tech review PR is in review by a developer label May 16, 2023

FRITS-Kh suggested changes May 16, 2023

View reviewed changes

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md Outdated Show resolved Hide resolved

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md Outdated Show resolved Hide resolved

CC-25662: Fix after TL review

4f48c3b

andrew-maslov added the 202400 PR contains document for the upcoming release 202400 label May 18, 2023

andrew-maslov added 2 commits May 29, 2023 10:27

CC-25660: Updated GitHub action section for migration guide.

0303b88

CC-25660: Updated dependencies in the migration guide

2e1981f

andrew-maslov requested review from VadymSachenko, lenadoc, AlexSlawinski and andriitserkovnyi as code owners May 30, 2023 06:11

FRITS-Kh suggested changes May 30, 2023

View reviewed changes

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md Outdated Show resolved Hide resolved

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md Outdated Show resolved Hide resolved

andrew-maslov added 2 commits May 30, 2023 15:37

CC-25660: Updated migration guide according with Tch Lead review

e474112

CC-25660: Added info block for migration guide

88db13f

FRITS-Kh previously approved these changes May 30, 2023

View reviewed changes

VadymSachenko suggested changes May 30, 2023

View reviewed changes

CC-25660: Fixed according to TW review

3b281b8

andrew-maslov dismissed FRITS-Kh’s stale review via 3b281b8 May 30, 2023 14:19

andrew-maslov and others added 2 commits May 30, 2023 17:40

CC-25660: Fixed according to TW review

3353f82

Merge branch 'master' into feature/cc-25660-update-nodejs-to-v18

da0a57d

VadymSachenko previously approved these changes May 30, 2023

View reviewed changes

FRITS-Kh suggested changes May 30, 2023

View reviewed changes

docs/scos/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18.md Outdated Show resolved Hide resolved

VadymSachenko added ready for merge The PR can be merged and removed in tech review PR is in review by a developer labels May 31, 2023

VadymSachenko changed the title ~~CC-25660: Migration Guide Update Node.js to v18~~ Migration guide - Upgrade Node.js to v18 and npm to v9 May 31, 2023

VadymSachenko added the new PR contains a new document label May 31, 2023

Vadym Sachenko added 3 commits June 1, 2023 10:20

Merge branch 'master' into feature/cc-25660-update-nodejs-to-v18

5c3210a

review

a697ab8

Merge branch 'master' into feature/cc-25660-update-nodejs-to-v18

8663441

VadymSachenko dismissed their stale review via 8663441 June 1, 2023 09:05

Merge branch 'master' into feature/cc-25660-update-nodejs-to-v18

4d97d36

VadymSachenko reviewed Jun 1, 2023

View reviewed changes

...os/dev/front-end-development/202304.0/migration-guide-upgrade-nodejs-to-v18-and-npm-to-v9.md Outdated Show resolved Hide resolved

Update docs/scos/dev/front-end-development/202304.0/migration-guide-u…

f54d38e

…pgrade-nodejs-to-v18-and-npm-to-v9.md

VadymSachenko approved these changes Jun 1, 2023

View reviewed changes

Vadym Sachenko added 2 commits June 1, 2023 15:18

Merge branch 'master' into feature/cc-25660-update-nodejs-to-v18

5c9b07e

Merge branch 'master' into feature/cc-25660-update-nodejs-to-v18

fdce2b1

FRITS-Kh approved these changes Jun 1, 2023

View reviewed changes

VadymSachenko merged commit fe8c72f into master Jun 1, 2023

VadymSachenko deleted the feature/cc-25660-update-nodejs-to-v18 branch June 1, 2023 16:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration guide - Upgrade Node.js to v18 and npm to v9 #1854

Migration guide - Upgrade Node.js to v18 and npm to v9 #1854

andrew-maslov commented May 16, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023 •

edited

Loading

VadymSachenko May 30, 2023

VadymSachenko May 30, 2023


		## Overview

		According to [Node.js schedule](https://github.com/nodejs/release#release-schedule) the 16 version will be maintained till 11.09.2023. So Spryker recommends migrating to 18 LTS version.


		## 1) Update configuration files

		1. Set up new versions of `node/npm` in the main `*.yml` files, like `deploy.yml`, `deploy.dev.yml`, and `deploy.ci.yml`:

	1. Set up new versions of `node/npm` in the main `*.yml` files, like `deploy.yml`, `deploy.dev.yml`, and `deploy.ci.yml`:
	1. In the main `*.yml` files, set up new versions of `node/npm`, like `deploy.yml`, `deploy.dev.yml`, and `deploy.ci.yml`:


		{% endinfo_block %}

		2. In the root directory, create/update `.nvmrc` file with the following content:

	2. In the root directory, create/update `.nvmrc` file with the following content:
	2. In the root directory, create or update the `.nvmrc` file with the following content:

	3. Update or add dependencies and engines in the `package.json`:
	3. In the `package.json`, update or add dependencies and engines:

	4. Remove dependency in the `package.json`:
	4. In the `package.json`, remove the dependency :

	- Replace `options` of `postcss-loader`;
	1. In `postcss-loader`, replace `options`.


		{% info_block infoBox "Note" %}

		Ensure that the `package-lock.json` file has `"lockfileVersion": 2` or higher, otherwise need to remove `node_modules` and `package-lock.json`. After that regenerate again.

	In case using GitHub Actions on the project need to update `.github/workflows/ci.yml` file.
	If you're using GitHub Actions on the project, update the `.github/workflows/ci.yml` file.

Migration guide - Upgrade Node.js to v18 and npm to v9 #1854

Migration guide - Upgrade Node.js to v18 and npm to v9 #1854

Conversation

andrew-maslov commented May 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VadymSachenko May 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VadymSachenko May 30, 2023 •

edited

Loading