Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: signals in Oryx #1989
docs: signals in Oryx #1989
Changes from 8 commits
bfef562
4b98e40
88318bf
09ea18c
e60c009
ca1b85b
6ee1c8c
ab91ffe
16d376a
1892c2f
f474f76
1316320
1281fba
60f5aa5
ac8113a
ecaac73
50d4cab
ed07cce
f8902f4
8761e3a
2776488
e6510ed
193e78a
510f481
14ea221
853d8b7
a0f0782
f8df1fb
16dd513
2462a79
94caf7b
e3ee9c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, avoid future tenses as much as possible. Also, this sentence looks unclear, so consider rephrasing or splitting it into two smaller ones: "In the preceding example, the
logProductCode
effect automatically starts whenMyComponent
is connected to the DOM, logging the product code every time, and the $product signal updates."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improved