Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPESC-769 Install the Product Rating and Reviews feature #2054

Merged
merged 9 commits into from
Aug 3, 2023

Conversation

artem-png
Copy link
Contributor

@artem-png artem-png added the updated PR contains meaningful changes to some document label Aug 1, 2023
@@ -11,7 +11,7 @@ redirect_from:
- /docs/product-rating-reviews-feature-integration
- /docs/en/product-rating-reviews-feature-integration
- /docs/scos/dev/feature-integration-guides/202307.0/product-rating-and-reviews-feature-integration.html
- /docs/scos/dev/feature-integration-guides/202307.0/product-rating-and-reviews-feature-integration.html
- /docs/scos/dev/feature-integration-guides/202307.0/product-rating-and-reviews-feature-integration.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the same line as previous one.

mikost7
mikost7 previously approved these changes Aug 2, 2023
Copy link
Collaborator

@mikost7 mikost7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@VadymSachenko VadymSachenko dismissed stale reviews from mikost7 and kkicheglovspryker via 833f4f8 August 3, 2023 09:48
@VadymSachenko VadymSachenko requested a review from a team as a code owner August 3, 2023 09:48
```

5. Set up resync feature:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean this?

Suggested change
5. Set up resync feature:
5. Set up and resync the feature:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Fixed to 'Add synchronization plugins:' (we have this wording everywhere)

}
```

6. Set up event trigger feature:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I get the confirmation that we have this "event trigger" feature? How do we spell it officially?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to 'Enable event trigger plugins to be able to re-trigger publish events.', as we have these wording almost everywhere. Feature link - https://docs.spryker.com/docs/scos/dev/back-end-development/data-manipulation/data-publishing/implement-event-trigger-publisher-plugins.html

@VadymSachenko VadymSachenko added the ready for merge The PR can be merged label Aug 3, 2023
@VadymSachenko VadymSachenko merged commit 5e255ce into master Aug 3, 2023
@VadymSachenko VadymSachenko deleted the bugfix/supesc-769-improve-product-review-ig branch August 3, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge The PR can be merged updated PR contains meaningful changes to some document
Development

Successfully merging this pull request may close these issues.

4 participants