Update jenkins-stability-checklist.md #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed non supported checklist boxes fixed non working image reference
ThomasLehnerSpryker
added
the
TW review needed
ThomasLehnerSpryker
requested review from
andriitserkovnyi and
lenadoc
as code owners
lenadoc
suggested changes
Mar 12, 2024
|
|
||
| - Configure a maximum of two executors. | ||
| - Set your PHP `memory_limit` value to be less than 2 GB. | ||
| - Implement batch processing (guidelines are here and here) in your importers and be mindful of the maximum memory consumption. |
There was a problem hiding this comment.
@ThomasLehnerSpryker please add the links to guidelines
| - Avoid spawning an excessive number of worker. There should be no more than two workers per queue. | ||
| - Profile your jobs locally to understand their normal memory demand, especially when interacting with data. | ||
| - In a standard-sized non-production environment, run lengthy imports and sync processes lasting more than 1-2 hours. | ||
| - Refer to troubleshooting instructions for further assistance. |
There was a problem hiding this comment.
What troubleshooting instructions do you mean here?
There was a problem hiding this comment.
Can be removed, the sentence before should read "do not run"
lenadoc
suggested changes
Mar 13, 2024
|
|
||
| - Configure a maximum of two executors. | ||
| - Set your PHP `memory_limit` value to be less than 2 GB. | ||
| - Implement batch processing (guidelines are here and here) in your importers and be mindful of maximum memory consumption. |
There was a problem hiding this comment.
@ThomasLehnerSpryker please add the links to guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed non supported checklist boxes
fixed non working image reference
PR Description
TBD
Checklist