Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-34932 Add Merchant Promotions & Discount feature IG #2990

Conversation

AsonUnique
Copy link
Contributor

@AsonUnique AsonUnique added tech review needed PR needs tech review new PR contains a new document 202400 PR contains document for the upcoming release 202400 labels Dec 16, 2024
@AsonUnique AsonUnique self-assigned this Dec 16, 2024
ilyakubanov
ilyakubanov previously approved these changes Dec 16, 2024

{% info_block warningBox "Verification" %}

1. [Create a discount](/docs/pbc/all/discount-management/{{site.version}}/base-shop/manage-in-the-back-office/create-discounts.html) and define its condition as a query string with a `merchant-refernce` field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. [Create a discount](/docs/pbc/all/discount-management/{{site.version}}/base-shop/manage-in-the-back-office/create-discounts.html) and define its condition as a query string with a `merchant-refernce` field.
1. [Create a discount](/docs/pbc/all/discount-management/{{site.version}}/base-shop/manage-in-the-back-office/create-discounts.html) and define its condition as a query string with a `merchant-reference` field.

{% info_block warningBox "Verification" %}

1. [Create a discount](/docs/pbc/all/discount-management/{{site.version}}/base-shop/manage-in-the-back-office/create-discounts.html) and define its condition as a query string with a `merchant-refernce` field.
2. Add a product sold by the defined merchant to the cart.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Add a product sold by the defined merchant to the cart.
2. Add a product sold by the defined in the newly created discount merchant to the cart.

How about something like this? Now it is not very clear what defined merchant means

template: feature-integration-guide-template
---

{% include pbc/all/install-features/{{page.version}}/install-the-merchant-promotions-and-discounts-feature.md %} <!-- To edit, see /_includes/pbc/all/install-features/202505.0/install-the-merchant-promotions-and-discounts-feature.md -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% include pbc/all/install-features/{{page.version}}/install-the-merchant-promotions-and-discounts-feature.md %} <!-- To edit, see /_includes/pbc/all/install-features/202505.0/install-the-merchant-promotions-and-discounts-feature.md -->
{% include pbc/all/install-features/{{page.version}}/marketplace/install-the-merchant-promotions-and-discounts-feature.md %} <!-- To edit, see /_includes/pbc/all/install-features/202505.0/marketplace/install-the-merchant-promotions-and-discounts-feature.md -->

@AsonUnique AsonUnique added TW review needed PR needs Technical writer's review and removed tech review needed PR needs tech review labels Dec 17, 2024

| NAME | VERSION | INSTALLATION GUIDE |
|------------------------|------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Marketplace Merchant | {{page.version}} | [Install the Marketplace Merchant feature](/docs/pbc/all/merchant-management/{{page.version}}/marketplace/install-and-upgrade/install-features/install-the-marketplace-merchant-feature.html) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this connector be called Marketplace Merchant + Promotions & Discounts feature?

@andriitserkovnyi andriitserkovnyi merged commit b71a51a into master Jan 3, 2025
3 checks passed
@andriitserkovnyi andriitserkovnyi deleted the hakathon/feature/cc-34932/dev-merchant-discount-condition branch January 3, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202400 PR contains document for the upcoming release 202400 new PR contains a new document TW review needed PR needs Technical writer's review
Development

Successfully merging this pull request may close these issues.

3 participants