Skip to content

Commit

Permalink
Merge pull request #160 from spsanderson/development
Browse files Browse the repository at this point in the history
Fixes #155
  • Loading branch information
spsanderson authored Nov 22, 2023
2 parents 115328d + 3082195 commit c7b3968
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 15 deletions.
5 changes: 3 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ will return an extra class of `gee_linear_reg`

## Minor Fixes and Improvements
1. Fix #142 - Add `gee`, `glmnet`, and `rules` to the `core_packages()` function.
2. Fix #148 - Update `create_model_spec()`
3. Fix #156 - Update `internal_set_args_to_tune()` to use `dplyr::pick()` instead
2. Fix #148 - Update `create_model_spec()`
3. Fix #155 - Add class `tidyaml_base_tbl` to the output of `create_model_spec()`
4. Fix #156 - Update `internal_set_args_to_tune()` to use `dplyr::pick()` instead
of `dplyr::cur_data()` since it was deprecated.

# tidyAML 0.0.2
Expand Down
12 changes: 5 additions & 7 deletions R/make-model-spec.R
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,16 @@
#' create_model_spec(
#' .parsnip_eng = list("lm","glm","glmnet","cubist"),
#' .parsnip_fns = list(
#' rep(
#' "linear_reg", 3),
#' "cubist_rules"
#' "linear_reg","linear_reg","linear_reg",
#' "cubist_rules"
#' )
#' )
#'
#' create_model_spec(
#' .parsnip_eng = list("lm","glm","glmnet","cubist"),
#' .parsnip_fns = list(
#' rep(
#' "linear_reg", 3),
#' "cubist_rules"
#' "linear_reg","linear_reg","linear_reg",
#' "cubist_rules"
#' ),
#' .return_tibble = FALSE
#' )
Expand Down Expand Up @@ -105,7 +103,7 @@ create_model_spec <- function(.parsnip_eng = list("lm"),
.model_spec = models
)

class(ret_tbl) <- c("create_mod_spec_tbl", class(ret_tbl))
class(ret_tbl) <- c(class(ret_tbl), "create_mod_spec_tbl", "tidyaml_base_tbl")

ifelse(ret_tibble, return(ret_tbl), return(models_list))
}
10 changes: 4 additions & 6 deletions man/create_model_spec.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c7b3968

Please sign in to comment.