Fix time_ns() freeze rounding error #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior of time_ns() mock did round the value of the frozen date to the seconds, excluding the microseconds if specified This is mostly problematic when freeze_time() is used with the uuid1() method: multiple "frozen" dates within the same second would all generate the same uuid
romuald
commented
Mar 20, 2024
| assert time.time() == expected_timestamp | ||
| assert time.time_ns() == expected_timestamp * 1e9 | ||
| freezer.stop() | ||
| with freezer: |
There was a problem hiding this comment.
This is totally unrelated: this test will crash pytest if the time_ns() function raises an error
There was a problem hiding this comment.
I'm not sure I understand your comment. On an error, wouldn't the __exit__ code run, and thus NOT cause any other test side effects? I'm failing to see an issue, could you please elaborate?
There was a problem hiding this comment.
The issue was present before the change. My comment should have said "did" crash and not "will" crash 😑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior of time_ns() mock did round the value of the frozen date to the seconds, excluding the microseconds if specified
This is mostly problematic when freeze_time() is used with the uuid1() method: multiple "frozen" dates within the same second would all generate the same uuid