Allow default_ignore_list to be empty
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `configure(default_ignore_list=[])` was equivalent to default_ignore_list=None. It should instead set the ignore list to nothing.
kingbuzzman
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for freezegun!
I wanted to disable the default ignore list, but I noticed that
configure(default_ignore_list=[])is equivalent todefault_ignore_list=None. I believe it should instead ignore nothing.I added a
is not None, and a test.I added the same test for
test_extend_default_ignore_list, but since None and [] are equivalent there, that doesn't need code changes.