Fix the potential memcpy to itself, in case SDL_numGestureTouches is zero #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmikushin : Good catch. I guess it's definitely a bug, but here is just a mirror. Please file against official Bugzilla https://bugzilla.libsdl.org/ to patch official repository. |
|
Dear @okuoku could you please kindly help me to upsteam this to the libsdl bugzilla. I fully understand and respect developers' preference, but filling a PR here is the most effort I can contribute. |
|
@dmikushin : Would you mind me to file issue to the bugzilla instead of you? If so, I'll take care of this. |
|
Merged as 0925e77 https://hg.libsdl.org/SDL/rev/17d911637a65 (Please close this PR once you've confirmed.) |
|
This was moved to libsdl-org/SDL#3977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==389919== Thread 1:
==389919== Source and destination overlap in memcpy(0x732abf0, 0x732abf0, 8240)
==389919== at 0x4C32513: memcpy@@GLIBC_2.14 (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==389919== by 0x460C2C: SDL_memcpy_REAL (SDL_string.c:321)
==389919== by 0x440132: SDL_GestureDelTouch (SDL_gesture.c:490)
==389919== by 0x444EE7: SDL_DelTouch (SDL_touch.c:460)
==389919== by 0x444F21: SDL_TouchQuit (SDL_touch.c:469)
==389919== by 0x477761: SDL_VideoQuit_REAL (SDL_video.c:2955)
==389919== by 0x58581D: SDL_QuitSubSystem_REAL (SDL.c:370)
==389919== by 0x5859C6: SDL_Quit_REAL (SDL.c:435)
==389919== by 0x432973: SDL_Quit (SDL_dynapi_procs.h:89)