Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spurious cache files in PyPI tarball #129

Closed
ghisvail opened this issue Aug 18, 2017 · 8 comments
Closed

Spurious cache files in PyPI tarball #129

ghisvail opened this issue Aug 18, 2017 · 8 comments
Assignees
Milestone

Comments

@ghisvail
Copy link
Contributor

Please take extra care with your future releases by ensuring they are done from a clean source tree. The current tarball on PyPI is riddled with cache files under qtpy/tests.

Thanks.

@ccordoba12 ccordoba12 added this to the v1.3.1 milestone Aug 18, 2017
@ccordoba12
Copy link
Member

Thanks @ghisvail, we'll fix this in 1.3.1

@rlaverde
Copy link
Member

This could be fixing changing this MANIFEST.in line https://github.com/spyder-ide/qtpy/blob/master/MANIFEST.in#L5

recursive-include qtpy/tests *

recursive-include qtpy/tests *.py

@ccordoba12
Copy link
Member

Great! Please open a PR about it.

@rlaverde
Copy link
Member

I was wrong, after some testing I realize that is not the problem, I don't know what the error could be, maybe we could add something like find . -name '*.pyc' -delete to the release instructions in the meanwhile 😞

@ghisvail
Copy link
Contributor Author

You need a combination of both, i.e. a filter in MANIFEST.in which is restrictive enough, plus a release process which ensures that the tarball is generated from a clean environment. I can help for the former (PR to follow shortly), but the latter is in your hands.

@ccordoba12
Copy link
Member

There's a git command that removes all files not under version control. I'll add it to our release notes to prevent this in the future.

@ghisvail
Copy link
Contributor Author

There's a git command that removes all files not under version control.

Indeed, a git clean -fd prior to running python setup.py sdist should be enough.

I'll update the Debian package with version 1.3.1 then.

@ccordoba12
Copy link
Member

ccordoba12 commented Aug 21, 2017

@ghisvail, I just released 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants