Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalInstance, Slot, and Property for Qt6 QtCore #274

Closed
tlambert03 opened this issue Nov 7, 2021 · 1 comment · Fixed by #271
Closed

SignalInstance, Slot, and Property for Qt6 QtCore #274

tlambert03 opened this issue Nov 7, 2021 · 1 comment · Fixed by #271
Assignees
@dalthviz
Labels
type:Enhancement
Milestone
v2.0.0

Comments

@tlambert03
Copy link
Contributor

I notice that PyQt6.QtCore.pyqtBoundSignal, pyqtProperty, and pyqtSlot were omitted from #225 and #229. Any reason? just lacking a PR to add them back?
@tlambert03 tlambert03 mentioned this issue Nov 7, 2021
Closed
@CAM-Gerlach CAM-Gerlach mentioned this issue Nov 7, 2021
Merged
@CAM-Gerlach CAM-Gerlach linked a pull request Nov 7, 2021 that will close this issue
PR: Unscoped enums access for PyQt6 and other missing PyQt6 compatibility changes #271
Merged
@CAM-Gerlach
Copy link
Member

Hey @tlambert03 , thanks for this! The reason would be that #225 and #229 are primarily focused on adding support for PySide6, while #233 is concerned with PyQt6 and mentions this issue (first pointed out by @tomgoddard ), and in fact PR #271 adds them back. Sorry if that wasn't clear!

@ccordoba12 ccordoba12 added this to the v2.0.0 milestone Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalthviz dalthviz

Labels
type:Enhancement
Projects
None yet
Milestone
v2.0.0
4 participants
@ccordoba12 @tlambert03 @dalthviz @CAM-Gerlach