Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyqtProperty->Property and pyqtBoundSignal->SignalInstance #275

Closed
wants to merge 2 commits into from
Closed

Add pyqtProperty->Property and pyqtBoundSignal->SignalInstance #275

wants to merge 2 commits into from

Conversation

tlambert03
Copy link
Contributor

closes #274

didn't wait for your response... but just in case it was an oversight, this adds back some of the PyQt6 specific logic around signals and properties in QtCore.

@CAM-Gerlach
Copy link
Member

Hey @tlambert03 , thanks for this. Sorry it wasn't clear from the title or the description, but it looks like all the changes here, save the QDateTime.toPyDateTime alias, are already made in PR #271 . As that is very nearly a superset of these changes, and this would need a fixup on your end or a squash on ours to fix the duplicate commits and add more appropriate commit messages, for simplicity's sake and to reduce merge conflicts, I'm thinking it might be best to add the QDateTime.toPython line to #271 (since its almost ready) assuming @dalthviz agrees, and give you a Co-authored-by: credit on the relevant commit there. How does that sound to you?

@tlambert03
Copy link
Contributor Author

sounds good! no need to for the co-authored-by... it's just a copy and paste job from pyqt5 :)
sorry I missed the addition in #271!

@tlambert03 tlambert03 closed this Nov 7, 2021
@tlambert03 tlambert03 deleted the add-prop-etc branch November 7, 2021 21:36
@CAM-Gerlach
Copy link
Member

No worries, thanks again for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignalInstance, Slot, and Property for Qt6 QtCore
2 participants