Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patch that "may be limited to PySide-5.11a1 only" #405

Closed
StSav012 opened this issue Feb 9, 2023 · 3 comments · Fixed by #407
Closed

Remove patch that "may be limited to PySide-5.11a1 only" #405

StSav012 opened this issue Feb 9, 2023 · 3 comments · Fixed by #407
Assignees
@StSav012
Labels
type:Task
Milestone
v2.3.1

Comments

@StSav012
Copy link
Contributor

StSav012 commented Feb 9, 2023

Providing

qtpy/qtpy/__init__.py

Line 148 in 441560d

PYSIDE2_VERSION_MIN = '5.12.0'
should lines

qtpy/qtpy/QtCore.py

Lines 81 to 84 in 441560d

try: # may be limited to PySide-5.11a1 only
from PySide2.QtGui import QStringListModel
except Exception:
pass

be removed for good? Anyway, the bare Exception looks ugly.
@CAM-Gerlach
Copy link
Member

Thanks for reporting! Seems like it; on Qt 5.12 it's in QtCore so no bespoke import needed. Want to submit a PR?

@StSav012
Copy link
Contributor Author

StSav012 commented Feb 9, 2023

It wouldn't hurt if the code stays there several more days, right? I'd like to make some more commits in another PR first.

@CAM-Gerlach
Copy link
Member

Sure, of course not—take your time. Thanks!

StSav012 added a commit to StSav012/qtpy that referenced this issue Feb 11, 2023
@StSav012
Remove patch that “may be limited to PySide-5.11a1 only”
dfeb5a8 
See spyder-ide#405
@StSav012 StSav012 mentioned this issue Feb 11, 2023
Merged
@CAM-Gerlach CAM-Gerlach linked a pull request Feb 14, 2023 that will close this issue
PR: Remove patch that may be limited to PySide-5.11a1 only #407
Merged
@dalthviz dalthviz added this to the v2.3.1 milestone Feb 14, 2023
StSav012 added a commit to StSav012/qtpy that referenced this issue Feb 21, 2023
@StSav012
Remove patch that “may be limited to PySide-5.11a1 only”
e0ef0b1 
See spyder-ide#405
@dalthviz dalthviz changed the title Remove patch that “may be limited to PySide-5.11a1 only” Remove patch that "may be limited to PySide-5.11a1 only" Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StSav012 StSav012

Labels
type:Task
Projects
None yet
Milestone
v2.3.1
Development

Successfully merging a pull request may close this issue.

PR: Remove patch that may be limited to PySide-5.11a1 only StSav012/qtpy
3 participants
@StSav012 @dalthviz @CAM-Gerlach