PR: Update Readme to mention that we now support PySide2. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
May 9, 2017
README.md
Outdated
| @@ -19,8 +19,8 @@ Copyright © 2009- The Spyder Development Team. | |||
| **QtPy** is a small abstraction layer that lets you | |||
| write applications using a single API call to either PyQt or PySide. | |||
|
|
|||
| It provides support for PyQt5, PyQt4 and PySide using the PyQt5 layout (where | |||
| the QtGui module has been split into QtGui and QtWidgets). | |||
| It provides support for PyQt5, PyQt4, PySide2 and PySide using the PyQt5 layout | |||
There was a problem hiding this comment.
Please change here
... using the PyQt5 layout
to
.. using the Qt 5 layout
|
It looks good. I just added a minor comment. |
goanpeca
reviewed
May 9, 2017
| It provides support for PyQt5, PyQt4 and PySide using the PyQt5 layout (where | ||
| the QtGui module has been split into QtGui and QtWidgets). | ||
| It provides support for PyQt5, PyQt4, PySide2 and PySide using the Qt5 layout | ||
| (where the QtGui module has been split into QtGui and QtWidgets). | ||
|
|
||
| Basically, you write your code as if you were using PyQt5 but import Qt modules |
There was a problem hiding this comment.
@ccordoba12 @rlaverde we should change this to
Basically, you write your code as if you were using PySide2 but import Qt modules from qtpy instead of PySide2 (or PyQt5)
Which is what we actually do, because we use Signal instead of (PyQt5Signal) for instance....
There was a problem hiding this comment.
@rlaverde, please open a new PR for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111