Revert "raise exception if old methods are called" #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 722e745. Conflicts fixed in qtpy/tests/test_patch_qheaderview.py
|
@cpascual, I agree with your rationale for this PR, but instead of simply removing those exceptions, could you add a warning about those deprecated methods using the |
|
No prob. I'll push as soon as I get it done. |
|
Thanks! I'm sorry for not giving you feedback before about your work,
but I hope we can merge it soon.
El 27/07/17 a las 09:29, Carlos Pascual escribió:
…
No prob. I'll push as soon as I get it done.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWS7UG6XJxDw49aQSyb3FYh_9m-hJBIks5sSJ63gaJpZM4N99Pd>.
|
|
I pushed the solution with your suggested approach in a separate PR ( #121 ) in order not to "revert the reverted" |
|
@cpascual so should we close this one? |
Yes, unless you want to reconsider it (see #121 (comment) ). Actually, I wrote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #119 by reverting commit 722e745