PR: Add QtHelp Wrapper #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
reviewed
Aug 18, 2017
qtpy/QtHelp.py
Outdated
| elif PYSIDE2: | ||
| # Current wheels don't have this module | ||
| # from PySide2.QtHelp | ||
| pass |
There was a problem hiding this comment.
But, this would result in a successful import. Should we at least add a warning?
There was a problem hiding this comment.
If we are going to add a warning we should add it to qtmultimedia too
There was a problem hiding this comment.
Yeah, we should add warning to this one and also QtMultimedia.
|
I created a custom warning? is that ok? or should I just use the standard warning |
ccordoba12
reviewed
Aug 20, 2017
qtpy/__init__.py
Outdated
| @@ -98,6 +98,9 @@ class PythonQtError(Exception): | |||
| """Error raise if no bindings could be selected""" | |||
| pass | |||
|
|
|||
| class PythonQtWarning(Warning): | |||
| """Warning if somefearures are not implemented in a binding.""" | |||
There was a problem hiding this comment.
Please fix the spelling here.
I think it's ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127