PR: Don't warn about bindings change if user did not specify a binding #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the purpose of this PR? Please be more specific. |
|
If the user doesn't specify a binding, qtpy tries to use pyqt5. If pyqt5 is not found and pyside is used, qtpy produces a warning. I believe this warning should only happen if the user explicitly requested a specific binding. If no binding was specified, it's safe to say he doesn't care which binding is used. Also, it is arbitrary to throw a warning with pyside and not with pyqt5 (since neither was requested by the user). |
ccordoba12
changed the title
ccordoba12
changed the title
ccordoba12
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Thanks for contribution @ignamv!! (and sorry for the late reply).
I modified your work a little bit to work with any binding previously set by users.
|
Note: The Circle failures are unrelated to this. |
ccordoba12
changed the title
|
No problem, thank you for qtpy!
…On Tue, Mar 5, 2019, 07:41 Carlos Cordoba ***@***.***> wrote:
Note: The Circle failures are unrelated to this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#176 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAY7K5UviLx6CxFNaSopF-tpgi-zmpObks5vTkm9gaJpZM4Y-4QK>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.