Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Avoid deprecated "from collections import MutableMapping" #187

Merged
merged 2 commits into from
May 4, 2019
Merged

PR: Avoid deprecated "from collections import MutableMapping" #187

merged 2 commits into from
May 4, 2019

Conversation

davvid
Copy link
Contributor

@davvid davvid commented May 3, 2019

Silence deprecation warnings seen on Python3.7:

    qtpy/py3compat.py:76:
    DeprecationWarning: Using or importing the ABCs from 'collections'
    instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
    
        from collections import MutableMapping

@davvid davvid mentioned this pull request May 3, 2019
Merged
@davvid
Copy link
Contributor Author

davvid commented May 3, 2019

(I'm sure y'all already know this -- but to save you the trouble of clicking through the error logs)
The CI failure is unrelated to these changes: ImportError: libQtWebKit.so.4: cannot open shared object file: No such file or directory.

Python3.5 doesn't seem to have the right runtime environment.

@ccordoba12 ccordoba12 changed the title Avoid deprecated "from collections import MutableMapping" PR: Avoid deprecated "from collections import MutableMapping" May 3, 2019
@ccordoba12 ccordoba12 added this to the v1.7.1 milestone May 3, 2019
@ccordoba12
Copy link
Member

Please rebase or merge with master to get the fix to our tests.

davvid added 2 commits May 4, 2019 00:15
@davvid
py3compat: compare ints to determine PY2 and PY3
96a9b44 
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid
py3compat: avoid deprecated "from collections import MutableMapping"
059b26e 
MutableMapping migrated to `collections.abc` in Python3.3 and will be
removed from `collections` in Python3.8.

Use `collections.abc` in Python3.3+ to silence deprecation warnings
seen on Python3.7.  `qtpy` is now Python3.8-compatible.

Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid
Copy link
Contributor Author

davvid commented May 4, 2019

Rebased.

@ccordoba12 ccordoba12 merged commit ca95bb8 into spyder-ide:master May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@davvid @ccordoba12