-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add FORCE_QT_API environment variable #194
Conversation
…rted python bindings.
It looks like the python 2.7 tests fail due to an update to shiboken2 as PySide has been bumped from 5.12.3 -> 5.13 on June 27. Previous run on master: https://circleci.com/gh/spyder-ide/qtpy/686 Release history of Shiboken2: https://pypi.org/project/shiboken2/#history You'll need to address these changes at some point as anyone trying to use Qtpy on that version will experience an error when using the Qt3DAnimation module. |
Thanks for working on this @JasonGilholme. I will open a new issues to track the problem -> see #195 |
No problem.
Has there ever been any discussion regarding joining efforts with the Qt.py
project?
I'm assuming they'll have to fix the same problem unless they have a design
that tolerates this sort of thing.
#192 (comment)
Regarding a comment posted on my original issue, you could say that the
gain would be more development resources.
|
Yes, they were but I guess the author of Qt.Py had different goals in mind and decided to create a new project with an unfortunate (similar) name. |
Interesting, from your point of view, do you see a major difference in the goals of the two projects? Don't get me started on the names. It's bad enough having 2 libs let alone having basically the same names. |
To be honest I do not know what qt.py does since we do not use it. I think the author wanted to have a shim in a single file instead of the way we chose to do it with separate files etc... Regarding the name, well it is really not our fault since this project was created first. |
It's unfortunate that implementation detail has been confused with goals in
this regard.
For the VFX industry, it shouldn't be long until we could drop the need for
a shim layer completely. This PR is still needed for us to continue to
enjoy using qtawesome though.
…On Sat, Jul 6, 2019, 8:37 AM Gonzalo Peña-Castellanos < ***@***.***> wrote:
Interesting, from your point of view, do you see a major difference in the
goals of the two projects?
To be honest I do not know what qt.py does since we do not use it. I think
the author wanted to have a shim in a single file instead of the way we
chose to do it with separate files etc...
Regarding the name, well it is really not our fault since this project was
created first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#194?email_source=notifications&email_token=ACNKFOKQM4UEEL2S4UBCQZDP57EKTA5CNFSM4H6N3MTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKM44A#issuecomment-508874352>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACNKFOJSYT5KP4ILNZRHJ63P57EKTANCNFSM4H6N3MTA>
.
|
FORCE_QT_API
environment variable
@JasonGilholme, please rebase in top of master to get the fix to our failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready because the failure is unrelated to @JasonGilholme changes (as noted above).
In response to this thread:
#192
-J
Fixes #192.