Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add support for QtSerialPort add-on #209

Merged
merged 1 commit into from
Aug 24, 2021
Merged

PR: Add support for QtSerialPort add-on #209

merged 1 commit into from
Aug 24, 2021

Conversation

Stanowczo
Copy link
Contributor

@Stanowczo Stanowczo commented Feb 27, 2020 •
edited
Loading

This adds support for QtSerialPort add-on. Unfortunately for now it is only available in PyQt5, not even in PySide2.

goanpeca
goanpeca approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Stanowczo for working on this

@goanpeca goanpeca added this to the Sprint 02 - II milestone Feb 27, 2020
@ccordoba12 ccordoba12 modified the milestones: Sprint 03 - II, v2.0.0 Aug 23, 2021
@ccordoba12 ccordoba12 changed the title Added support for QtSerialPort add-on PR: Add support for QtSerialPort add-on Aug 23, 2021
@ccordoba12 ccordoba12 modified the milestones: v2.0.0, v1.11.0 Aug 23, 2021
@dalthviz
Copy link
Member

Closing (and reopening) to trigger CI run

@dalthviz dalthviz closed this Aug 24, 2021
@dalthviz dalthviz reopened this Aug 24, 2021
dalthviz
dalthviz approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Stanowczo ! LGTM 👍

@dalthviz dalthviz merged commit ecf1063 into spyder-ide:master Aug 24, 2021
@dalthviz dalthviz assigned Stanowczo and unassigned ccordoba12 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goanpeca goanpeca goanpeca approved these changes

@dalthviz dalthviz dalthviz approved these changes

Assignees

@Stanowczo Stanowczo

Labels
None yet
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Stanowczo @dalthviz @goanpeca @ccordoba12