Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add QtWinExtras module #218

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Jul 13, 2020

No description provided.

@jschueller
Copy link
Contributor

ping @goanpeca

@ccordoba12 ccordoba12 changed the title add QtWinExtras module PR: Add QtWinExtras module Aug 23, 2021
@ccordoba12 ccordoba12 added this to the v1.11.0 milestone Aug 23, 2021
@dalthviz
Copy link
Member

Closing (and reopening) to trigger CI run

@dalthviz dalthviz closed this Aug 24, 2021
@dalthviz dalthviz reopened this Aug 24, 2021
@dalthviz
Copy link
Member

Hi @phil65 thank you for your contribution! Seems like QtWinExtras is not available on conda with Python 3 and on pip it doesn't have some modules or maybe the access is different (like QtWinExtras.QtWin) Could you do a check and do the validations for the test to pass? Let us know!

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution @phil65!

@ccordoba12 ccordoba12 merged commit 2f24b27 into spyder-ide:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants