Add missing trove classifiers with setup-py-upgrade and setup-cfg-fmt #223
Conversation
pipx run setup-cfg-fmt --min-py3-version=3.3 --max-py-version=3.8 -- setup.cfg
| Programming Language :: Python :: 3.6 | ||
| Programming Language :: Python :: 3.7 | ||
| Programming Language :: Python :: 3.8 |
There was a problem hiding this comment.
these are the only supported python versions
There was a problem hiding this comment.
Do we really still support Python 3.3 and 3.4? They're long-obsolete, Spyder itself dropped them ages ago.
There was a problem hiding this comment.
This should be resolved in PR #208 ; you'll need to re-run your tooling once that's merged since it changes a bunch of the metadata
CAM-Gerlach
changed the title
| Programming Language :: Python :: 3.6 | ||
| Programming Language :: Python :: 3.7 | ||
| Programming Language :: Python :: 3.8 |
There was a problem hiding this comment.
Do we really still support Python 3.3 and 3.4? They're long-obsolete, Spyder itself dropped them ages ago.
| 'Programming Language :: Python :: 3.4', | ||
| 'Programming Language :: Python :: 3.5'] | ||
| ) | ||
| setup(version=version_ns['__version__']) |
There was a problem hiding this comment.
The version attr can be specified declaratively, as e.g. I do here, so this last bit of dynamic code in the setup.py can be eliminated
| maintainer = Gonzalo Peña-Castellanos | ||
| maintainer_email = goanpeca@gmail.com | ||
| license = MIT | ||
| license_file = LICENSE.txt |
There was a problem hiding this comment.
license_file is deprecated and license_files should be used instead, and in any case LICENSE.txt will be included automatically, so this can just be removed.
| license_file = LICENSE.txt |
|
Thanks for your help with this @graingert. We already updated our classifiers in 1.10.0 and don't accustom to declare metadata in So we decided to close this one, but thanks for your interest in improving this project. |
|
Is there a reason you prefer the legacy metadata format? @ccordoba12 |
|
It's just a matter of being used to do that in all our projects. So we prefer to keep things like that for now. |
I noticed there were no supported python versions (py3.6, py3.7 and py3.8) in the pypi metadata